Repository navigation
[UR][L0] Return false for UR_DEVICE_INFO_MEMORY_EXPORT_EXPORTABLE_DEVICE_MEM_EXP if no types are supported - #23613
Conversation
…ICE_MEM_EXP if no types are supported Signed-off-by: Nick Sarnie <nick.sarnie@intel.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
1 open issue
What changed in this PR
Updates Level Zero adapter device info reporting so UR_DEVICE_INFO_MEMORY_EXPORT_EXPORTABLE_DEVICE_MEM_EXP returns false when the underlying driver doesn’t support exporting device allocations to any external memory handle types, preventing feature-dependent tests from failing on drivers that lack support.
Changes:
- Replace unconditional
truereturn with a Level Zero external memory capability query. - Treat
ZE_RESULT_ERROR_UNSUPPORTED_FEATUREas “not supported” and otherwise propagate errors.
| File | Description |
|---|---|
| unified-runtime/source/adapters/level_zero/common/device.cpp | Query Level Zero external memory properties to determine if device memory export is actually supported. |
Review effort: Lite
There was a problem hiding this comment.
Overall looks good to me.
I think we will need to update the spec in the future as follow up.
Maybe it's worth to open issue for it @0x12CC @cperkinsintel your thoughts?
Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
| return ReturnValue( | ||
| Device->ZeDeviceExternalMemoryProperties->memoryAllocationExportTypes != | ||
| 0); |
|
@intel/llvm-gatekeepers please consider merging |
Right now we always return true, on some internal graphics drivers used for CRI testing we are seeing that it is not suppported so tests using this feature fail.
Return false if no types are supported.
Leave more specific checks to be defined in future versions of the sycl_ext_oneapi_memory_export spec, which explicitly says this query is not currently supported well.
CMPLRLLVM-75929